linux-kernel - Re: [PATCH v2 2/2] Input: edt-ft5x06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Apr 2024 20:56:53 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: dmitry.torokhov@...il.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 o.rempel@...gutronix.de, u.kleine-koenig@...gutronix.de,
 hdegoede@...hat.com, ye.xingchen@....com.cn, p.puschmann@...onex.com,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, caleb.connolly@...aro.org
Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add ft5426

On Fri, 5 Apr 2024 20:21:19 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Apr 5, 2024 at 7:28 PM Andreas Kemnade <andreas@...nade.info> wrote:
> > On Fri, 5 Apr 2024 18:13:45 +0300
> > Andy Shevchenko <andy.shevchenko@...il.com> wrote:  
> > > On Fri, Apr 5, 2024 at 1:20 AM Andreas Kemnade <andreas@...nade.info> wrote:  
> 
> ...
> 
> > > > @@ -1484,6 +1484,7 @@ static const struct of_device_id edt_ft5x06_of_match[] = {
> > > >         { .compatible = "edt,edt-ft5206", .data = &edt_ft5x06_data },
> > > >         { .compatible = "edt,edt-ft5306", .data = &edt_ft5x06_data },
> > > >         { .compatible = "edt,edt-ft5406", .data = &edt_ft5x06_data },
> > > > +       { .compatible = "focaltech,ft5426", .data = &edt_ft5506_data },  
> > >
> > > Why a different vendor prefix?
> > > In case you need to use this one, keep the list sorted, currently this
> > > splits the edt,* ones.
> > >  
> > How do I know whether to use evervision or edt instead?  
> 
> Ask DT people, the vendor-prefixes lists both...
> 
> > I sorted by the numbers. Looking at datasheets for other controllers I see
> > https://www.displayfuture.com/Display/datasheet/controller/FT5x06.pdf
> > it only mentions FocalTech Systems Co., Ltd.  
> 
> But does the driver use that? AFAICS it uses edt. Perhaps it's due to
> a business split, not to my knowledge anyway.
> 
well, the fact is that there were several tried to add duplicates to this
driver to the kernel using focaltech prefixes e.g.
https://lore.kernel.org/linux-input/47209259-9e57-f263-bf48-10f233c63b69@redhat.com/

My guess it is somehow about owner of the firmware in the chip vs the chip itself.

Regards,
Andreas