linux-kernel - Re: [PATCH net] u64_stats: fix u64_stats_init() for lockdep when used repeatedly in one file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLZ9rkSpT6crP89RV-GPSnSxhUkjPSSh3PmiLNDH103yQ@mail.gmail.com>
Date: Fri, 5 Apr 2024 23:08:58 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Petr Tesarik <petr@...arici.cz>
Cc: "David S. Miller" <davem@...emloft.net>, open list <netdev@...r.kernel.org>, 
	Linux regressions mailing list <regressions@...ts.linux.dev>, open list <linux-kernel@...r.kernel.org>, 
	"Linux regression tracking (Thorsten Leemhuis)" <regressions@...mhuis.info>
Subject: Re: [PATCH net] u64_stats: fix u64_stats_init() for lockdep when used
 repeatedly in one file

On Thu, Apr 4, 2024 at 9:58 AM Petr Tesarik <petr@...arici.cz> wrote:
>
> Fix bogus lockdep warnings if multiple u64_stats_sync variables are
> initialized in the same file.
>
> With CONFIG_LOCKDEP, seqcount_init() is a macro which declares:
>
>         static struct lock_class_key __key;
>
> Since u64_stats_init() is a function (albeit an inline one), all calls
> within the same file end up using the same instance, effectively treating
> them all as a single lock-class.
>
> Fixes: 9464ca650008 ("net: make u64_stats_init() a function")
> Closes: https://lore.kernel.org/netdev/ea1567d9-ce66-45e6-8168-ac40a47d1821@roeck-us.net/
> Signed-off-by: Petr Tesarik <petr@...arici.cz>

I thought I gave a Reviewed-by: tag already...

Reviewed-by: Eric Dumazet <edumazet@...gle.com>