linux-kernel - Re: [PATCH] mm: page_alloc: use the correct THP order for THP PCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4xvXT6Qy1JgP2khH0DKvTGhjsrexsSj8ddieM_XXn8bng@mail.gmail.com>
Date: Fri, 5 Apr 2024 17:53:24 +1300
From: Barry Song <21cnbao@...il.com>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc: akpm@...ux-foundation.org, mgorman@...hsingularity.net, vbabka@...e.cz, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: page_alloc: use the correct THP order for THP PCP

On Thu, Apr 4, 2024 at 2:47 AM Baolin Wang
<baolin.wang@...ux.alibaba.com> wrote:
>
> Commit 44042b449872 ("mm/page_alloc: allow high-order pages to be stored
> on the per-cpu lists") extends the PCP allocator to store THP pages, and
> it determines whether to cache THP pags in PCP by comparing with pageblock_order.
> But the pageblock_order is not always equal to THP order, it might also
> be MAX_PAGE_ORDER, which could prevent PCP from caching THP pages.
>
> Therefore, using HPAGE_PMD_ORDER instead to determine the need for caching
> THP for PCP can fix this issue
>
> Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists")
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

LGTM,
Reviewed-by: Barry Song <baohua@...nel.org>

In the context of using mTHP, perhaps there arises a need for PCP
allocation for frequently
requested mTHP orders. These orders typically exceed PAGE_ALLOC_COSTLY_ORDER
but are smaller than HPAGE_PMD_ORDER.

> ---
>  mm/page_alloc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1beb56f75319..915f4ef070da 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -506,7 +506,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order)
>  {
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>         if (order > PAGE_ALLOC_COSTLY_ORDER) {
> -               VM_BUG_ON(order != pageblock_order);
> +               VM_BUG_ON(order != HPAGE_PMD_ORDER);
>                 return NR_LOWORDER_PCP_LISTS;
>         }
>  #else
> @@ -522,7 +522,7 @@ static inline int pindex_to_order(unsigned int pindex)
>
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>         if (pindex == NR_LOWORDER_PCP_LISTS)
> -               order = pageblock_order;
> +               order = HPAGE_PMD_ORDER;
>  #else
>         VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER);
>  #endif
> @@ -535,7 +535,7 @@ static inline bool pcp_allowed_order(unsigned int order)
>         if (order <= PAGE_ALLOC_COSTLY_ORDER)
>                 return true;
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> -       if (order == pageblock_order)
> +       if (order == HPAGE_PMD_ORDER)
>                 return true;
>  #endif
>         return false;
> --
> 2.39.3
>

Thanks
Barry