linux-kernel - Re: [PATCH 2/2] mfd: rohm-bd71828: Add software-compatible variant BD71879

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240405063518.GA6194@google.com>
Date: Fri, 5 Apr 2024 07:35:18 +0100
From: Lee Jones <lee@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, mazziesaccount@...il.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: rohm-bd71828: Add software-compatible variant
 BD71879

On Tue, 02 Apr 2024, Andreas Kemnade wrote:

> Add the BD71879 PMIC which is software-compatible to the BD71828, so reuse
> the same device_type enum.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> Suggested-by: Matti Vaittinen <mazziesaccount@...il.com>
> ---
>  drivers/mfd/rohm-bd71828.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c
> index 4a1fa8a0d76a..f0b444690d4d 100644
> --- a/drivers/mfd/rohm-bd71828.c
> +++ b/drivers/mfd/rohm-bd71828.c
> @@ -585,6 +585,10 @@ static const struct of_device_id bd71828_of_match[] = {
>  	{
>  		.compatible = "rohm,bd71828",
>  		.data = (void *)ROHM_CHIP_TYPE_BD71828,
> +	}, {
> +		.compatible = "rohm,bd71879",
> +		/* equivalent from a software point of view */

Nit: Sentences start with capital letters.

> +		.data = (void *)ROHM_CHIP_TYPE_BD71828,
>  	}, {
>  		.compatible = "rohm,bd71815",
>  		.data = (void *)ROHM_CHIP_TYPE_BD71815,
> -- 
> 2.39.2
> 

-- 
Lee Jones [李琼斯]