linux-kernel - Re: [PATCH v3 06/14] mm/ksm: use ksm_get_folio in scan_get_next_rmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Apr 2024 09:28:31 +0200
From: David Hildenbrand <david@...hat.com>
To: alexs@...nel.org, Matthew Wilcox <willy@...radead.org>,
 Andrea Arcangeli <aarcange@...hat.com>,
 Izik Eidus <izik.eidus@...ellosystems.com>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, ryncsn@...il.com
Cc: Hugh Dickins <hughd@...gle.com>, Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH v3 06/14] mm/ksm: use ksm_get_folio in
 scan_get_next_rmap_item

On 25.03.24 13:48, alexs@...nel.org wrote:
> From: "Alex Shi (tencent)" <alexs@...nel.org>
> 
> Save a compound calls.
> 
> Signed-off-by: Alex Shi (tencent) <alexs@...nel.org>
> Cc: Izik Eidus <izik.eidus@...ellosystems.com>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Andrea Arcangeli <aarcange@...hat.com>
> Cc: Hugh Dickins <hughd@...gle.com>
> Cc: Chris Wright <chrisw@...s-sol.org>
> ---
>   mm/ksm.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/ksm.c b/mm/ksm.c
> index aa80fbf3a8e0..95a487a21eed 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -2611,14 +2611,14 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page)
>   		 */
>   		if (!ksm_merge_across_nodes) {
>   			struct ksm_stable_node *stable_node, *next;
> -			struct page *page;
> +			struct folio *folio;
>   
>   			list_for_each_entry_safe(stable_node, next,
>   						 &migrate_nodes, list) {
> -				page = get_ksm_page(stable_node,
> -						    GET_KSM_PAGE_NOLOCK);
> -				if (page)
> -					put_page(page);
> +				folio = ksm_get_folio(stable_node,
> +						      GET_KSM_PAGE_NOLOCK);
> +				if (folio)
> +					folio_put(folio);
>   				cond_resched();
>   			}
>   		}

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb