linux-kernel - Re: [PATCH v5.10] block: add check that partition length needs to be aligned with block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024040539-bonsai-nugget-9e60@gregkh>
Date: Fri, 5 Apr 2024 11:31:45 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ashwin Dayanand Kamat <ashwin.kamat@...adcom.com>
Cc: stable@...r.kernel.org, axboe@...nel.dk, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, ajay.kaher@...adcom.com,
	alexey.makhalov@...adcom.com, vasavi.sirnapalli@...adcom.com,
	Min Li <min15.li@...sung.com>, Damien Le Moal <dlemoal@...nel.org>,
	Chaitanya Kulkarni <kch@...dia.com>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v5.10] block: add check that partition length needs to be
 aligned with block size

On Tue, Apr 02, 2024 at 02:19:55PM +0530, Ashwin Dayanand Kamat wrote:
> From: Min Li <min15.li@...sung.com>
> 
> [ Upstream commit 6f64f866aa1ae6975c95d805ed51d7e9433a0016]
> 
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
> 
> Cc:  <stable@...r.kernel.org>
> Signed-off-by: Min Li <min15.li@...sung.com>
> Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
> Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Link: https://lore.kernel.org/r/20230629142517.121241-1-min15.li@samsung.com
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Ashwin Dayanand Kamat <ashwin.kamat@...adcom.com>
> ---
>  block/ioctl.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Now queued up,t hanks.,

greg k-h