linux-kernel - Re: [PATCH v3 5/7] staging: pi433: Remove duplicated code using the "goto" error recovery scheme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Apr 2024 12:05:56 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Shahar Avidar <ikobh7@...il.com>, linux-staging@...ts.linux.dev,
 kernel-janitors@...r.kernel.org,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 "Felix N. Kimbu" <felixkimbu1@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans Verkuil <hverkuil-cisco@...all.nl>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v3 5/7] staging: pi433: Remove duplicated code using the
 "goto" error recovery scheme.

I suggest to use the summary phrase “Use common error handling code
in pi433_init()” instead.

> pi433_init had "unregister_chrdev" called twice.
> Remove it using goto statements.

How do you think about to use the following change description?

   unregister_chrdev() was called in two if branches.
   Thus add jump targets so that a bit of exception handling can be better
   reused at the end of this function implementation.

…
v2->v3:
…
          a seperate patch.
…

Would you like to avoid a typo here?

Regards,
Markus