linux-kernel - Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Apr 2024 12:42:38 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Shahar Avidar <ikobh7@...il.com>, linux-staging@...ts.linux.dev,
 kernel-janitors@...r.kernel.org,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 "Felix N. Kimbu" <felixkimbu1@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans Verkuil <hverkuil-cisco@...all.nl>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of
 driver register fails.

I suggest to use the summary phrase “Call debugfs_remove() in case of
driver registration failure in pi433_init()” instead.

> debugfs resources were never cleaned in case of failure to register driver.

How do you think about to use a change description like the following?

   Debugfs resources were not released after a call of
   the function “spi_register_driver” failed.
   Thus fix the exception handling accordingly.

Regards,
Markus