linux-kernel - Re: [PATCH 4/7] soundwire: reconcile dp0_prop and dpn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zg_hcQ2RUBpkA_DG@matsya>
Date: Fri, 5 Apr 2024 17:03:05 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Bard Liao <yung-chuan.liao@...ux.intel.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	pierre-louis.bossart@...ux.intel.com, bard.liao@...el.com
Subject: Re: [PATCH 4/7] soundwire: reconcile dp0_prop and dpn_prop

On 26-03-24, 09:01, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> 
> The definitions for DP0 are missing a set of fields that are required
> to reuse the same configuration code as DPn.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Reviewed-by: Rander Wang <rander.wang@...el.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@...ux.intel.com>
> ---
>  include/linux/soundwire/sdw.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> index e5d0aa58e7f6..e3a4bccc2a7e 100644
> --- a/include/linux/soundwire/sdw.h
> +++ b/include/linux/soundwire/sdw.h
> @@ -235,7 +235,8 @@ enum sdw_clk_stop_mode {
>   * @BRA_flow_controlled: Slave implementation results in an OK_NotReady
>   * response
>   * @simple_ch_prep_sm: If channel prepare sequence is required
> - * @imp_def_interrupts: If set, each bit corresponds to support for
> +  * @ch_prep_timeout: Port-specific timeout value, in milliseconds
> +  * @imp_def_interrupts: If set, each bit corresponds to support for

why is this line modified? seems to be same as previous and leading
space added which might not be correct


>   * implementation-defined interrupts
>   *
>   * The wordlengths are specified by Spec as max, min AND number of
> @@ -249,6 +250,7 @@ struct sdw_dp0_prop {
>  	u32 *words;
>  	bool BRA_flow_controlled;
>  	bool simple_ch_prep_sm;
> +	u32 ch_prep_timeout;
>  	bool imp_def_interrupts;
>  };
>  
> -- 
> 2.34.1

-- 
~Vinod