linux-kernel - Re: [PATCH 0/3] Add REQ_F_CQE_SKIP support to io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3c0da47-8748-42ba-bd0e-872a5e66090f@gmail.com>
Date: Fri, 5 Apr 2024 13:06:40 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Oliver Crumrine <ozlinuxc@...il.com>, axboe@...nel.dk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, shuah@...nel.org, leitao@...ian.org
Cc: io-uring@...r.kernel.org, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Add REQ_F_CQE_SKIP support to io_uring zerocopy

On 4/4/24 23:16, Oliver Crumrine wrote:
> This patchset allows for io_uring zerocopy to support REQ_F_CQE_SKIP,
> skipping the normal completion notification, but not the zerocopy buffer
> release notification.

It's an io_uring internal change not altering how it operates
with the net layer, you don't need to CC the net list.

> This patchset also includes a test to test these changes, and a patch to
> mini_liburing to enable io_uring_peek_cqe, which is needed for the test.

For the same reason tests should be in liburing, where all io_uring tests
are, and the selftest can be dropped. See liburing/test/send-zerocopy.c


> Oliver Crumrine (3):
>    io_uring: Add REQ_F_CQE_SKIP support for io_uring zerocopy
>    io_uring: Add io_uring_peek_cqe to mini_liburing
>    io_uring: Support IOSQE_CQE_SKIP_SUCCESS in io_uring zerocopy test
> 
>   io_uring/net.c                                |  6 +--
>   tools/include/io_uring/mini_liburing.h        | 18 +++++++++
>   .../selftests/net/io_uring_zerocopy_tx.c      | 37 +++++++++++++++++--
>   .../selftests/net/io_uring_zerocopy_tx.sh     |  7 +++-
>   4 files changed, 59 insertions(+), 10 deletions(-)
> 

-- 
Pavel Begunkov