linux-kernel - Re: [PATCH v2 1/1] serial: 8250_of: Add clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240405144611.4b741c63@bootlin.com>
Date: Fri, 5 Apr 2024 14:46:11 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Bastien Curutchet <bastien.curutchet@...tlin.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
 <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, christophercordahi@...ometrics.ca
Subject: Re: [PATCH v2 1/1] serial: 8250_of: Add clock_notifier

Hi Bastien,

On Fri,  5 Apr 2024 14:05:52 +0200
Bastien Curutchet <bastien.curutchet@...tlin.com> wrote:

> The UART's input clock rate can change at runtime but this is not
> handled by the driver.
> 
> Add a clock_notifier callback that updates the divisors when the input
> clock is updated. The serial8250_update_uartclk() is used to do so.
> PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
> the POST_RATE_CHANGE is used. Not using PRE_RATE_CHANGE notification can
> result in a few corrupted bytes during frequency transitions but, IMHO,
> it can be acceptable in many use cases.
> 
> It has been tested on a DAVINCI/OMAP-L138 processor.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@...tlin.com>

Reviewed-by: Herve Codina <herve.codina@...tlin.com>

Best regards,
Hervé