linux-kernel - Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y19s7bk6.fsf@mail.lhotse>
Date: Fri, 05 Apr 2024 14:06:33 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Andy Shevchenko <andy.shevchenko@...il.com>, Finn Thain
 <fthain@...ux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
 <jirislaby@...nel.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>,
 Nicholas Piggin <npiggin@...il.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, "Aneesh Kumar K.V"
 <aneesh.kumar@...nel.org>, "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
 linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq
 flood

Andy Shevchenko <andy.shevchenko@...il.com> writes:
> On Thu, Apr 4, 2024 at 2:57 AM Finn Thain <fthain@...ux-m68k.org> wrote:
>> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
>
>> > > Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> > > Cc: Michael Ellerman <mpe@...erman.id.au>
>> > > Cc: Nicholas Piggin <npiggin@...il.com>
>> > > Cc: Christophe Leroy <christophe.leroy@...roup.eu>
>> > > Cc: "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>
>> > > Cc: "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
>> > > Cc: linux-m68k@...ts.linux-m68k.org
>> >
>> > Second, please move these Cc to be after the '---' line
>>
>> I thought they were placed above the line for audit (and signing)
>> purposes.
>
> I didn't get this, sorry.
>
>> There are thousands of Cc lines in the mainline commit messages
>> since v6.8.
>
> Having thousands of mistaken cases does not prove it's a good thing to
> follow. I answered Jiri why it's better the way I suggested.
>
>> > > Link: https://github.com/vivier/qemu-m68k/issues/44
>> > > Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/
>> >
>> > Missed Fixes tag?
>>
>> Would this be ok: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> I have to ask because some reviewers do not like to see a Fixes tag cite
>> that commit.
>
> Yes, or you even may dig into the history.git from history group (see
> git.kernel.org) for the real first patch that brought it.
>
>> > > Signed-off-by: Finn Thain <fthain@...ux-m68k.org>
>> > > ---
>> > (here is a good location for Cc:)
>>
>> Documentation/process/submitting-patches.rst indicats that it should be
>> above the "---" separator together with Acked-by etc. Has this convention
>> changed recently?

The docs don't really say where to put the Cc: tags, although they are
mentioned along with other tags which clearly are intended to go above
the separator.

> I see, I will prepare a patch to discuss this aspect.

FYI there was a discussion about this several years ago, where at least
some maintainers agreed that Cc: tags don't add much value and are
better placed below the --- separator.

Thread starts here: https://lore.kernel.org/all/87y31eov1l.fsf@concordia.ellerman.id.au/

cheers