linux-kernel - Re: [PATCH v2 2/2] Input: edt-ft5x06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeZ9U_+1rJQjr4KvvzjYQGzfKtk+BK00vqvKcVn2-yP3g@mail.gmail.com>
Date: Fri, 5 Apr 2024 18:13:45 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: dmitry.torokhov@...il.com, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	o.rempel@...gutronix.de, u.kleine-koenig@...gutronix.de, hdegoede@...hat.com, 
	ye.xingchen@....com.cn, p.puschmann@...onex.com, linux-input@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	caleb.connolly@...aro.org
Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add ft5426

On Fri, Apr 5, 2024 at 1:20 AM Andreas Kemnade <andreas@...nade.info> wrote:
>
> As ft5426 seems to be compatible with this driver, add it.
> Debug output during identification: Model "generic ft5x06 (79)", Rev. "

..

> @@ -1484,6 +1484,7 @@ static const struct of_device_id edt_ft5x06_of_match[] = {
>         { .compatible = "edt,edt-ft5206", .data = &edt_ft5x06_data },
>         { .compatible = "edt,edt-ft5306", .data = &edt_ft5x06_data },
>         { .compatible = "edt,edt-ft5406", .data = &edt_ft5x06_data },
> +       { .compatible = "focaltech,ft5426", .data = &edt_ft5506_data },

Why a different vendor prefix?
In case you need to use this one, keep the list sorted, currently this
splits the edt,* ones.

>         { .compatible = "edt,edt-ft5506", .data = &edt_ft5506_data },
>         { .compatible = "evervision,ev-ft5726", .data = &edt_ft5506_data },
>         /* Note focaltech vendor prefix for compatibility with ft6236.c */

-- 
With Best Regards,
Andy Shevchenko