linux-kernel - Re: [PATCH 1/2] selftests: Replace "Bail out" with "Error"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404050832.35AE5A95@keescook>
Date: Fri, 5 Apr 2024 08:32:33 -0700
From: Kees Cook <keescook@...omium.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Eric Biederman <ebiederm@...ssion.com>, Shuah Khan <shuah@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...labora.com
Subject: Re: [PATCH 1/2] selftests: Replace "Bail out" with "Error"

On Fri, Apr 05, 2024 at 06:17:47PM +0500, Muhammad Usama Anjum wrote:
> "Bail out! " is not descriptive. It rather should be: "Failed: " and
> then that added prefix doesn't need to be added everywhere. Usually in
> the logs, we are searching for "Failed" or "Error" instead of "Bail
> out".
> 
> Suggested-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook