linux-kernel - Re: [PATCH v5 00/11] scsi: ufs: Remove overzealous memory barriers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq15xwvs3fl.fsf@ca-mkp.ca.oracle.com>
Date: Fri, 05 Apr 2024 21:09:06 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Manivannan Sadhasivam
 <mani@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin
 K. Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke
 <hare@...e.de>, Janek Kotas <jank@...ence.com>,
        Alim Akhtar
 <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bart Van
 Assche <bvanassche@....org>, Can Guo <quic_cang@...cinc.com>,
        Anjana
 Hari <quic_ahari@...cinc.com>, Will Deacon <will@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH v5 00/11] scsi: ufs: Remove overzealous memory barriers


Andrew,

> Please review with care as I'm not all that confident in this subject.
> UFS has a lot of mb() variants used, most with comments saying "ensure
> this takes effect before continuing". mb()'s aren't really the way to
> guarantee that, a read back is the best method.

Applied to 6.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering