linux-kernel - Re: [PATCH 2/2] tracing/selftests: Default to verbose mode when running in kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <470d67f2-dd6f-48e1-8f42-a6c72e2d98e7@collabora.com>
Date: Sun, 7 Apr 2024 02:05:10 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Mark Brown <broonie@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Shuah Khan <shuah@...nel.org>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Mark Rutland <mark.rutland@....com>, Aishwarya TCV <aishwarya.tcv@....com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 2/2] tracing/selftests: Default to verbose mode when
 running in kselftest

On 3/25/24 9:15 PM, Mark Brown wrote:
> In order to facilitate debugging of issues from automated runs of the ftrace
> selftests turn on verbose logging by default when run from the kselftest
> runner. This is primarily used by automated systems where developers may
> not have direct access to the system so defaulting to providing diagnostic
> information which might help debug problems seems like a good idea.
> 
> When tests pass no extra output is generated, when they fail a full log of
> the test run is provided. Since this really is rather verbose when there are
> a large number of test failures or output is slow (eg, with a serial
> console) this could substantially increase the run time for the tests which
> might present problems with timeout detection for affected systems,
> hopefully we keep the tests running well enough that this is not too much
> of an issue.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest-ktap b/tools/testing/selftests/ftrace/ftracetest-ktap
> index b3284679ef3a..14e62ef3f3b9 100755
> --- a/tools/testing/selftests/ftrace/ftracetest-ktap
> +++ b/tools/testing/selftests/ftrace/ftracetest-ktap
> @@ -5,4 +5,4 @@
>  #
>  # Copyright (C) Arm Ltd., 2023
>  
> -./ftracetest -K
> +./ftracetest -K -v
> 

-- 
BR,
Muhammad Usama Anjum