linux-kernel - Re: [RFC][PATCH 05/10] sched/fair: Unify pick_{,next_}_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c1127ff3b1718585bcb6374fb444b15b753cacb.camel@gmx.de>
Date: Sat, 06 Apr 2024 04:20:44 +0200
From: Mike Galbraith <efault@....de>
To: Peter Zijlstra <peterz@...radead.org>, mingo@...hat.com, 
 juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com,  rostedt@...dmis.org, bsegall@...gle.com,
 mgorman@...e.de, bristot@...hat.com,  vschneid@...hat.com,
 linux-kernel@...r.kernel.org
Cc: kprateek.nayak@....com, wuyun.abel@...edance.com, tglx@...utronix.de
Subject: Re: [RFC][PATCH 05/10] sched/fair: Unify pick_{,next_}_task_fair()

Greetings (good to see you back).

On Fri, 2024-04-05 at 12:27 +0200, Peter Zijlstra wrote:
> @@ -8440,19 +8439,20 @@ static struct task_struct *pick_task_fai
>  
>         return task_of(se);
>  }
> -#endif
>  
>  struct task_struct *
>  pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
>  {
> -       struct cfs_rq *cfs_rq = &rq->cfs;
>         struct sched_entity *se;
>         struct task_struct *p;
> +       struct cfs_rq *cfs_rq;
>         int new_tasks;
>  
>  again:
> -       if (!sched_fair_runnable(rq))
> +       p = pick_task_fair(rq);
> +       if (!p)
>                 goto idle;
> +       se = &p->se;
>  
>  #ifdef CONFIG_FAIR_GROUP_SCHED
>         if (!prev || prev->sched_class != &fair_sched_class)

Those who dodge GROUP_SCHED overhead receive a shiny new unused variable warning.

	-Mike