[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240407011913.GA168730@nchen-desktop>
Date: Sun, 7 Apr 2024 09:19:13 +0800
From: Peter Chen <peter.chen@...nel.org>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: chipidea: move ci_ulpi_init after the phy
initialization
On 24-04-02 08:23:43, Michael Grzeschik wrote:
> The function ci_usb_phy_init is already handling the
> hw_phymode_configure path which is also only possible after we have
> a valid phy. So we move the ci_ulpi_init after the phy initialization
> to be really sure to be able to communicate with the ulpi phy.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
Acked-by: Peter Chen <peter.chen@...nel.org>
> ---
> drivers/usb/chipidea/core.c | 8 ++++----
> drivers/usb/chipidea/ulpi.c | 5 -----
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 835bf2428dc6e..bada13f704b62 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -1084,10 +1084,6 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - ret = ci_ulpi_init(ci);
> - if (ret)
> - return ret;
> -
> if (ci->platdata->phy) {
> ci->phy = ci->platdata->phy;
> } else if (ci->platdata->usb_phy) {
> @@ -1142,6 +1138,10 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> goto ulpi_exit;
> }
>
> + ret = ci_ulpi_init(ci);
> + if (ret)
> + return ret;
> +
> ci->hw_bank.phys = res->start;
>
> ci->irq = platform_get_irq(pdev, 0);
> diff --git a/drivers/usb/chipidea/ulpi.c b/drivers/usb/chipidea/ulpi.c
> index dfec07e8ae1d2..89fb51e2c3ded 100644
> --- a/drivers/usb/chipidea/ulpi.c
> +++ b/drivers/usb/chipidea/ulpi.c
> @@ -68,11 +68,6 @@ int ci_ulpi_init(struct ci_hdrc *ci)
> if (ci->platdata->phy_mode != USBPHY_INTERFACE_MODE_ULPI)
> return 0;
>
> - /*
> - * Set PORTSC correctly so we can read/write ULPI registers for
> - * identification purposes
> - */
> - hw_phymode_configure(ci);
>
> ci->ulpi_ops.read = ci_ulpi_read;
> ci->ulpi_ops.write = ci_ulpi_write;
>
> ---
> base-commit: 5bab5dc780c9ed0c69fc2f828015532acf4a7848
> change-id: 20240328-chipidea-phy-misc-b3f2bc814784
>
> Best regards,
> --
> Michael Grzeschik <m.grzeschik@...gutronix.de>
>
--
Thanks,
Peter Chen
Powered by blists - more mailing lists