linux-kernel - Re: [syzbot] [bpf?] KASAN: stack-out-of-bounds Read in hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b764fde2-cbf3-6446-d437-45af0964b062@huaweicloud.com>
Date: Sun, 7 Apr 2024 17:09:28 +0800
From: Hou Tao <houtao@...weicloud.com>
To: syzbot <syzbot+9459b5d7fab774cf182f@...kaller.appspotmail.com>,
 bpf@...r.kernel.org, syzkaller-bugs@...glegroups.com, netdev@...r.kernel.org
Cc: andrii@...nel.org, ast@...nel.org, daniel@...earbox.net,
 eddyz87@...il.com, haoluo@...gle.com, john.fastabend@...il.com,
 kpsingh@...nel.org, jolsa@...nel.org, martin.lau@...ux.dev, sdf@...gle.com,
 song@...nel.org, yonghong.song@...ux.dev, linux-kernel@...r.kernel.org
Subject: Re: [syzbot] [bpf?] KASAN: stack-out-of-bounds Read in hash

Hi,

On 4/6/2024 9:44 PM, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:    443574b03387 riscv, bpf: Fix kfunc parameters incompatibil..
> git tree:       bpf
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=148ad855180000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=6fb1be60a193d440
> dashboard link: https://syzkaller.appspot.com/bug?extid=9459b5d7fab774cf182f
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13d86795180000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=143eff76180000

According to the reproducer, it passes a big value_size (0xfffffe00)
when creating bloom filter map. The big value_size bypasses the check in
check_stack_access_within_bounds(). I think a proper fix needs to add
these following two checks:
(1) in check_stack_access_within_bounds()  add check for negative
access_size
(2) in bloom_map_alloc() limit the max value of bloom_map_alloc().

Will post a patch to fix the syzbot report. Will also check whether or
not there are similar problems for other bpf maps.