linux-kernel - RE: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB9386F99C9E901337603E94FFE1012@AS4PR04MB9386.eurprd04.prod.outlook.com>
Date: Sun, 7 Apr 2024 09:24:26 +0000
From: Joy Zou <joy.zou@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Jacky Bai
	<ping.bai@....com>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC: "kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, dl-linux-imx <linux-imx@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc
 PCF2131 support



BR
Joy Zou

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 2024年4月7日 17:12
> To: Joy Zou <joy.zou@....com>; Jacky Bai <ping.bai@....com>;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de
> Cc: kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> <linux-imx@....com>; devicetree@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 07/04/2024 11:09, Joy Zou wrote:
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: 2024年4月7日 17:04
> >> To: Joy Zou <joy.zou@....com>; Jacky Bai <ping.bai@....com>;
> >> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> >> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de
> >> Cc: kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> >> <linux-imx@....com>; devicetree@...r.kernel.org; imx@...ts.linux.dev;
> >> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> >> Subject: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add
> >> rtc
> >> PCF2131 support
> >>> +&lpi2c3 {
> >>> +     #address-cells = <1>;
> >>> +     #size-cells = <0>;
> >>> +     clock-frequency = <400000>;
> >>> +     pinctrl-names = "default", "sleep";
> >>> +     pinctrl-0 = <&pinctrl_lpi2c3>;
> >>> +     pinctrl-1 = <&pinctrl_lpi2c3>;
> >>> +     status = "okay";
> >>> +
> >>> +     pcf2131: rtc@53 {
> >>> +                     compatible = "nxp,pcf2131";
> >>> +                     reg = <0x53>;
> >>> +                     interrupt-parent = <&pcal6524>;
> >>> +                     interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> >>> +                     status = "okay";
> >>
> >> Really, just drop...
> > Ok, will drop the status in next version.
> > Thanks for your comment!
> 
> Please read DTS coding style.
Thanks you very much!
Yeah, I have read the DTS coding style. The “status” property is by default “okay”, thus it can be omitted.
BR
Joy Zou
> 
> Best regards,
> Krzysztof