[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7eaf81b4-80b3-2728-0588-ecad6c137848@huawei.com>
Date: Sun, 7 Apr 2024 11:40:39 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: Nianyao Tang <tangnianyao@...wei.com>
CC: <maz@...nel.org>, <tglx@...utronix.de>,
<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<guoyang2@...wei.com>, <wangwudi@...ilicon.com>
Subject: Re: [RESPIN PATCH] irqchip/gic-v4.1:Fix VSYNC referencing an unmapped
VPE
On 2024/4/6 10:27, Nianyao Tang wrote:
> As per the GICv4.1 spec (Arm IHI 0069H, 5.3.19):
>
> "A VMAPP with {V, Alloc}=={0, x} is self-synchronizing, This means the
> ITS command queue does not show the command as consumed until all of
> its effects are completed."
>
> Furthermore, VSYNC is allowed to deliver an SError when referencing a
> non existent VPE.
>
> By these definitions, a VMAPP followed by a VSYNC is a bug, as the
> later references a VPE that has been unmapped by the former.
>
> Fix it by eliding the VSYNC in this scenario.
>
> Fixes: 64edfaa9a234 ("irqchip/gic-v4.1: Implement the v4.1 flavour of VMAPP")
>
> Signed-off-by: Nianyao Tang <tangnianyao@...wei.com>
> Reviewed-by: Marc Zyngier <maz@...nel.org>
Reviewed-by: Zenghui Yu <yuzenghui@...wei.com>
Thanks.
Powered by blists - more mailing lists