linux-kernel - Re: [PATCH] wifi: ar5523: enable proper endpoint verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 7 Apr 2024 11:29:00 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
        Kalle Valo
	<kvalo@...nel.org>
CC: Wu Yunchuan <yunchuan@...china.com>,
        Johannes Berg
	<johannes.berg@...el.com>,
        Breno Leitao <leitao@...ian.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>,
        <syzbot+1bc2c2afd44f820a669f@...kaller.appspotmail.com>
Subject: Re: [PATCH] wifi: ar5523: enable proper endpoint verification

On 4/7/2024 8:05 AM, Nikita Zhandarovich wrote:
[...]
> diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c
> index 815f8f599f5d..5cac4a6452db 100644
> --- a/drivers/net/wireless/ath/ar5523/ar5523.c
> +++ b/drivers/net/wireless/ath/ar5523/ar5523.c
> @@ -1594,6 +1594,20 @@ static int ar5523_probe(struct usb_interface *intf,
>  	struct ar5523 *ar;
>  	int error = -ENOMEM;
>  
> +	static u8 bulk_ep_addr[] = {

add 'const' qualifier

> +		AR5523_CMD_TX_PIPE | USB_DIR_OUT,
> +		AR5523_DATA_TX_PIPE | USB_DIR_OUT,
> +		AR5523_CMD_RX_PIPE | USB_DIR_IN,
> +		AR5523_DATA_RX_PIPE | USB_DIR_IN,
> +		0};
> +
> +	if (!usb_check_bulk_endpoints(intf, bulk_ep_addr)) {
> +		dev_err(&dev->dev,
> +			"Could not find all expected endpoints\n");
> +		error = -ENODEV;
> +		goto out;
> +	}
> +
>  	/*
>  	 * Load firmware if the device requires it.  This will return
>  	 * -ENXIO on success and we'll get called back afer the usb
>