linux-kernel - Re: [PATCH v4 3/5] spi: spi-qpic: Add qpic spi nand driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 7 Apr 2024 13:45:52 -0500
From: "Alex G." <mr.nuke.me@...il.com>
To: Md Sadre Alam <quic_mdalam@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, broonie@...nel.org, robh@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
 manivannan.sadhasivam@...aro.org, neil.armstrong@...aro.org,
 daniel@...rotopia.org, arnd@...db.de, chris.packham@...iedtelesis.co.nz,
 christophe.kerello@...s.st.com, linux-arm-msm@...r.kernel.org,
 linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Cc: quic_srichara@...cinc.com, quic_varada@...cinc.com
Subject: Re: [PATCH v4 3/5] spi: spi-qpic: Add qpic spi nand driver support



On 4/7/24 13:40, Alex G. wrote:
> 
> 
> On 4/7/24 12:48, Alex G. wrote:
>> On 3/8/24 03:17, Md Sadre Alam wrote:
>>> Add qpic spi nand driver support. The spi nand
>>> driver currently supported the below commands.
>>>
>>> -- RESET
>>> -- READ ID
>>> -- SET FEATURE
>>> -- GET FEATURE
>>> -- READ PAGE
>>> -- WRITE PAGE
>>> -- ERASE PAGE
>>>
>>> Co-developed-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
>>> Co-developed-by: Varadarajan Narayanan <quic_varada@...cinc.com>
>>> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
>>> Signed-off-by: Md Sadre Alam <quic_mdalam@...cinc.com>
>>> ---
>>
>> For the entire series:
>>
>> Tested-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
>>
>>> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
>>> index bc7021da2fe9..63764e943d82 100644
>>> --- a/drivers/spi/Kconfig
>>> +++ b/drivers/spi/Kconfig
>>> @@ -882,6 +882,14 @@ config SPI_QCOM_QSPI
>>>       help
>>>         QSPI(Quad SPI) driver for Qualcomm QSPI controller.
>>> +config SPI_QPIC_SNAND
>>> +    tristate "QPIC SNAND controller"
> 
> Also, don't tristate this. It can be set as CONFIG_QPIC_COMMON=m, which 
> will cause the build to fail because you don't have a MODULE_LICENSE().

Please disregard my idiotic suggestion here. I meant to make this 
comment on the previous patch.

>>> +    depends on ARCH_QCOM || COMPILE_TEST
>>
>> Here, it needs to 'select QPIC_COMMON`. Otherwise it can run into 
>> unresolved symbols:
>>
>> : drivers/spi/spi-qpic-snand.o: in function `snandc_set_reg':
>>   drivers/spi/spi-qpic-snand.c:56:(.text+0x484): undefined reference 
>> to `qcom_offset_to_nandc_reg'
>> ...
>>
>>> +    help
>>> +      QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller.
>>> +      QPIC controller supports both parallel nand and serial nand.
>>> +      This config will enable serial nand driver for QPIC controller.
>>> +
>>>   config SPI_QUP
>>>       tristate "Qualcomm SPI controller with QUP interface"
>>>       depends on ARCH_QCOM || COMPILE_TEST
>>
>> Alex
> Alex