linux-kernel - Re: [tip: x86/boot] x86/boot: Move kernel cmdline setup earlier in the boot process (again)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhQ3JSXT05Kv/RpM@gmail.com>
Date: Mon, 8 Apr 2024 20:27:49 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Borislav Petkov <bp@...en8.de>
Cc: x86-ml <x86@...nel.org>, linux-tip-commits@...r.kernel.org,
	Julian Stecklina <julian.stecklina@...erus-technology.de>,
	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [tip: x86/boot] x86/boot: Move kernel cmdline setup earlier in
 the boot process (again)


* Borislav Petkov <bp@...en8.de> wrote:

> On Fri, Mar 29, 2024 at 07:51:13AM -0000, tip-bot2 for Julian Stecklina wrote:
> > The following commit has been merged into the x86/boot branch of tip:
> > 
> > Commit-ID:     4faa0e5d6d79fc4c6e1943e8b62a65744d8439a0
> > Gitweb:        https://git.kernel.org/tip/4faa0e5d6d79fc4c6e1943e8b62a65744d8439a0
> > Author:        Julian Stecklina <julian.stecklina@...erus-technology.de>
> > AuthorDate:    Thu, 28 Mar 2024 16:42:12 +01:00
> > Committer:     Ingo Molnar <mingo@...nel.org>
> > CommitterDate: Fri, 29 Mar 2024 08:19:12 +01:00
> > 
> > x86/boot: Move kernel cmdline setup earlier in the boot process (again)
> 
> ...
> 
> > The order is now:
> > 
> > 	setup_arch():
> > 	  -> Assemble final command line:
> > 	     boot_command_line = builtin_cmdline + boot_cmdline
> > 
> > 	  -> early_cpu_init()
> > 	    -> early_identify_cpu()
> > 	      -> sld_setup()
> > 		-> sld_state_setup()
> > 		  -> Looks for split_lock_detect in boot_command_line
> > 
> > 	  -> e820__memory_setup()
> > 
> > 	  -> parse_early_param()
> 
> So that thing. Should we do something like the silly thing below so that 
> it catches potential issues with parsing builtin cmdline stuff too early?

Yep, that's a good idea.

Acked-by: Ingo Molnar <mingo@...nel.org>

	Ingo