linux-kernel - Re: [PATCH v5 1/3] ACPI: platform-profile: add platform_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 08 Apr 2024 22:13:01 +0200
From: Gergo Koteles <soyer@....hu>
To: Hans de Goede <hdegoede@...hat.com>,
  "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
  Ike Panhc <ike.pan@...onical.com>,
  Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
  Henrique de Moraes Holschuh <hmh@....eng.br>,
  Daniel Lezcano <daniel.lezcano@...aro.org>,
  Barnabás Pőcze <pobrn@...tonmail.com>
Cc: linux-acpi@...r.kernel.org, ibm-acpi-devel@...ts.sourceforge.net,
  platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] ACPI: platform-profile: add
 platform_profile_cycle()

Hi Hans,

On Mon, 2024-04-08 at 18:41 +0200, Hans de Goede wrote:
> > +	next = find_next_bit_wrap(cur_profile->choices,
> > +				  ARRAY_SIZE(profile_names), profile + 1);
> > +
> > +	if (WARN_ON(next == ARRAY_SIZE(profile_names))) {
> 
> Other code in drivers/acpi/platform_profile.c uses PLATFORM_PROFILE_LAST
> instead of ARRAY_SIZE(profile_names) (these are guaranteed to be equal)
> please switch to using PLATFORM_PROFILE_LAST for consistency.
> 

Thanks for the review. I changed these in v6.

Best regards,
Gergo