linux-kernel - Re: [PATCH] ext4: block_validity: Remove unnecessary ‘NULL’ values from new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4E5BC096-0EEC-467E-8C6B-276CF5BED332@dilger.ca>
Date: Mon, 8 Apr 2024 14:54:27 -0600
From: Andreas Dilger <adilger@...ger.ca>
To: Li zeming <zeming@...china.com>
Cc: Theodore Ts'o <tytso@....edu>,
 Ext4 Developers List <linux-ext4@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ext4: block_validity: Remove unnecessary ‘NULL’ values from new_node

On Apr 1, 2024, at 8:23 PM, Li zeming <zeming@...china.com> wrote:
> 
> new_node is assigned first, so it does not need to initialize the
> assignment.
> 
> Signed-off-by: Li zeming <zeming@...china.com>
> ---
> fs/ext4/block_validity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
> index 6fe3c941b5651..87ee3a17bd29c 100644
> --- a/fs/ext4/block_validity.c
> +++ b/fs/ext4/block_validity.c
> @@ -72,7 +72,7 @@ static int add_system_zone(struct ext4_system_blocks *system_blks,
> {
> 	struct ext4_system_zone *new_entry, *entry;
> 	struct rb_node **n = &system_blks->root.rb_node, *node;
> -	struct rb_node *parent = NULL, *new_node = NULL;
> +	struct rb_node *parent = NULL, *new_node;

This one is more compact and doesn't have the issue with
the "cleanup" label at the end.

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)