linux-kernel - Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <711e8a6a-a849-3cd3-fde3-d60f756abfa5@quicinc.com>
Date: Mon, 8 Apr 2024 14:31:45 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Bjorn Andersson <andersson@...nel.org>, Rob Clark <robdclark@...il.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        "Bjorn
 Andersson" <quic_bjorande@...cinc.com>
Subject: Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio
 operations



On 3/28/2024 7:40 AM, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@...cinc.com>
> 
> The dp_audio read and write operations uses members in struct dp_catalog
> for passing arguments and return values. This adds unnecessary
> complexity to the implementation, as it turns out after detangling the
> logic that no state is actually held in these variables.
> 
> Clean this up by using function arguments and return values for passing
> the data.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> ---
>   drivers/gpu/drm/msm/dp/dp_audio.c   | 20 +++++--------------
>   drivers/gpu/drm/msm/dp/dp_catalog.c | 39 +++++++++++++------------------------
>   drivers/gpu/drm/msm/dp/dp_catalog.h | 18 +++++++++--------
>   3 files changed, 28 insertions(+), 49 deletions(-)
> 

One quick question, was DP audio re-tested after this patch?