[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e037e303-47b3-4758-914c-980ebe88d450@moroto.mountain>
Date: Mon, 8 Apr 2024 09:35:18 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Jackson Chui <jacksonchui.qwerty@...il.com>
Cc: Alex Elder <elder@...e.org>, Johan Hovold <johan@...nel.org>,
Alex Elder <elder@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: Clear up precedence for gcam logging
macros
On Sat, Apr 06, 2024 at 06:35:22PM -0400, Jackson Chui wrote:
> > -Alex
>
> Dan, Alex I think both of you are spot on.
>
> I like the suggestion of adding 'gcam_dev()' as an accessor
> function and directly calling to 'dev_*'. I'm busy this weekend
> but will send out a new patch with this change next week.
Nah, don't bother with adding the gcam_dev() function. Like Alex says,
it's only 4 characters shorter. Just get rid of the macros and do:
dev_err(&gcam->bundle->dev,
"Unsupported unsolicited event: %u\n", op->type);
regards,
dan carpenter
Powered by blists - more mailing lists