linux-kernel - Re: [PATCH v2 1/9] MIPS: asm: Move strings to .rodata.str section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2654580f-aeac-45d9-b838-8d6cf8605bdc@linaro.org>
Date: Mon, 8 Apr 2024 08:48:26 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Jiaxun Yang <jiaxun.yang@...goat.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/9] MIPS: asm: Move strings to .rodata.str section

On 26/3/24 21:35, Jiaxun Yang wrote:
> Well, they are read only.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> ---
>   arch/mips/include/asm/asm.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/asm.h b/arch/mips/include/asm/asm.h
> index 2e99450f4228..05a158a8920c 100644
> --- a/arch/mips/include/asm/asm.h
> +++ b/arch/mips/include/asm/asm.h
> @@ -94,7 +94,7 @@ symbol:		.insn
>   symbol		=	value
>   
>   #define TEXT(msg)					\
> -		.pushsection .data;			\
> +		.pushsection .rodata.str;			\

Nitpicking, \ is now misaligned.

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>

>   8:		.asciiz msg;				\
>   		.popsection;
>   
>