linux-kernel - Re: [PATCH v3 14/14] mm/ksm: remove set_page_stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f8ab03f-7755-4044-81a1-6269aa9a62ed@gmail.com>
Date: Mon, 8 Apr 2024 15:00:46 +0800
From: Alex Shi <seakeel@...il.com>
To: David Hildenbrand <david@...hat.com>, alexs@...nel.org,
 Matthew Wilcox <willy@...radead.org>, Andrea Arcangeli
 <aarcange@...hat.com>, Izik Eidus <izik.eidus@...ellosystems.com>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, ryncsn@...il.com
Cc: Hugh Dickins <hughd@...gle.com>, Chris Wright <chrisw@...s-sol.org>
Subject: Re: [PATCH v3 14/14] mm/ksm: remove set_page_stable_node



On 4/5/24 3:32 PM, David Hildenbrand wrote:
> On 25.03.24 13:49, alexs@...nel.org wrote:
>> From: "Alex Shi (tencent)" <alexs@...nel.org>
>>
>> Remove the func since all caller are gone. Also remove the
>> VM_BUG_ON_PAGE() because it's not applicable for a folio.
> 
> Ehm, it is for small folios that we are working with here.
> 
> Please keep that check and convert it into a warn.
> 
> VM_WARN_ON_FOLIO(folio_test_anon(folio) && PageAnonExclusive(&folio->page), folio);

will take it. Thanks!

> 
>> -    page->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM);
>> -}
>> -
>>   static inline void folio_set_stable_node(struct folio *folio,
>>                        struct ksm_stable_node *stable_node)
>>   {
>> -    set_page_stable_node(&folio->page, stable_node);
>> +    folio->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM);
>>   }
>>     #ifdef CONFIG_SYSFS
> 
>