linux-kernel - Re: [PATCH v2] lib: checksum: hide unused expected_csum_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Apr 2024 08:49:39 +0100
From: Simon Horman <horms@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: netdev@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Palmer Dabbelt <palmer@...osinc.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Charlie Jenkins <charlie@...osinc.com>,
	Noah Goldstein <goldstein.w.n@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: checksum: hide unused expected_csum_ipv6_magic[]

On Thu, Apr 04, 2024 at 06:36:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When CONFIG_NET is disabled, an extra warning shows up for this
> unused variable:
> 
> lib/checksum_kunit.c:218:18: error: 'expected_csum_ipv6_magic' defined but not used [-Werror=unused-const-variable=]
> 
> Replace the #ifdef with an IS_ENABLED() check that makes the compiler's
> dead-code-elimination take care of the link failure.
> 
> Fixes: f24a70106dc1 ("lib: checksum: Fix build with CONFIG_NET=n")
> Suggested-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Acked-by: Palmer Dabbelt <palmer@...osinc.com>
> Acked-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> resending v2 to netdev

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested