linux-kernel - Re: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58b0a77d-8bcf-4d76-82a0-15bfc1cc2e43@nxp.com>
Date: Mon, 8 Apr 2024 10:50:02 +0300
From: Mirela Rabulea <mirela.rabulea@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 shawnguo@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 festevam@...x.de, festevam@...il.com, alexander.stein@...tq-group.com,
 Frank.li@....com, ming.qian@....com
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, mchehab@...nel.org, hverkuil@...all.nl,
 linux-media@...r.kernel.org, imx@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks
 entries

Hi Krzysztof,

On 08.04.2024 09:38, Krzysztof Kozlowski wrote:
> Please correct subject. You already got comments on this.
> https://lore.kernel.org/linux-devicetree/2fb8c43c-c079-e04e-f727-3bc1dc29996e@linaro.org/

Sorry I missed that.

I will update the prefix to "media: dt-bindings: nxp,imx8-jpeg:". as you 
suggested in v2.
>> Changes since v3:
>> - Add items for clocks (per Krzysztof's feddback)
>> - Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
>> - Add "media:" to the subject
> Where? It was there before, so what did you change?

I started from v3 here: 
https://lore.kernel.org/linux-devicetree/20230912163810.1750488-1-festevam@gmail.com/

The subject was: "[PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks 
entries", I had just added "media:". Anyways, will update it again.

>> +  clocks:
>> +    description:
>> +      The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
>> +      and one clock for it's core engine (AXI, same source as for the wrapper)
> Description is now redundant, drop it.

Ok, I will do so in v5.

Thanks a lot for feedback,

Mirela