linux-kernel - Re: [PATCH v3 06/10] perf/dwc_pcie: Avoid placing cpumask on the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62202a1b-0bb8-42f5-8956-cd8ff82b4ff0@linux.alibaba.com>
Date: Mon, 8 Apr 2024 08:30:37 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Dawei Li <dawei.li@...ngroup.cn>, will@...nel.org, mark.rutland@....com,
 yury.norov@...il.com, linux@...musvillemoes.dk
Cc: renyu.zj@...ux.alibaba.com, yangyicong@...ilicon.com,
 jonathan.cameron@...wei.com, andersson@...nel.org, konrad.dybcio@...aro.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 06/10] perf/dwc_pcie: Avoid placing cpumask on the
 stack



On 2024/4/3 23:59, Dawei Li wrote:
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
> 
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
> 
> Suggested-by: Mark Rutland <mark.rutland@....com>
> Reviewed-by: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Dawei Li <dawei.li@...ngroup.cn>

Reviewed-by: Shuai Xue <xueshuai@...ux.alibaba.com>

Thank you.

Shuai