linux-kernel - Re: [PATCH 1/4] dev_printk: add new dev_errp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 08 Apr 2024 10:57:02 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>, Nuno Sa <nuno.sa@...log.com>
Cc: Petr Mladek <pmladek@...e.com>, Jonathan Cameron <jic23@...nel.org>, 
 Lars-Peter Clausen <lars@...afoo.de>, Olivier Moysan
 <olivier.moysan@...s.st.com>, Jyoti Bhayana <jbhayana@...gle.com>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>,  Chris Down
 <chris@...isdown.name>, John Ogness <john.ogness@...utronix.de>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
 linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/4] dev_printk: add new dev_errp_probe() helper

On Sat, 2024-04-06 at 20:35 +0200, Andi Shyti wrote:
> Hi Nuno,
> 
> ...
> 
> > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned. */
> > +#define dev_errp_probe(dev, ___err, fmt, ...)	({		\
> > +	ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__));	\
> > +})
> 
> I have a whole series adding a set of error oriente printk's. But
> for the time being this looks OK.
> 
> I just don't like the name, the 'p' is an important detail, but
> a bit hidden... how about dev_err_ptr_probe(...)?
> 

Agreed, not a very good name indeed.

- Nuno Sá