linux-kernel - Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <702594ec5852c482f96cfcf84a02cab2@linux.ibm.com>
Date: Mon, 08 Apr 2024 12:03:10 +0200
From: Harald Freudenberger <freude@...ux.ibm.com>
To: Allen Pais <apais@...ux.microsoft.com>
Cc: linux-kernel@...r.kernel.org, tj@...nel.org, keescook@...omium.org,
        vkoul@...nel.org, marcan@...can.st, sven@...npeter.dev,
        florian.fainelli@...adcom.com, rjui@...adcom.com,
        sbranden@...adcom.com, paul@...pouillou.net,
        Eugeniy.Paltsev@...opsys.com, manivannan.sadhasivam@...aro.org,
        vireshk@...nel.org, Frank.Li@....com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, haijie1@...wei.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        afaerber@...e.de, logang@...tatee.com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr, andersson@...nel.org,
        konrad.dybcio@...aro.org, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org, wens@...e.org,
        jernej.skrabec@...il.com, peter.ujfalusi@...il.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        jassisinghbrar@...il.com, mchehab@...nel.org,
        maintainers@...echerrydvr.com, aubin.constans@...rochip.com,
        ulf.hansson@...aro.org, manuel.lauss@...il.com,
        mirq-linux@...e.qmqm.pl, jh80.chung@...sung.com, oakad@...oo.com,
        hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
        brucechang@....com.tw, HaraldWelte@...tech.com, pierre@...man.eu,
        duncan.sands@...e.fr, stern@...land.harvard.edu, oneukum@...e.com,
        openipmi-developer@...ts.sourceforge.net, dmaengine@...r.kernel.org,
        asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        imx@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
        linux-mediatek@...ts.infradead.org, linux-actions@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, Holger Dengler <dengler@...ux.ibm.com>
Subject: Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

On 2024-03-27 17:03, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context 
> is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH 
> workqueue
> behaves similarly to regular workqueues except that the queued work 
> items
> are executed in the BH context.
> 
> This patch converts drivers/infiniband/* from tasklet to BH workqueue.
> 
> Based on the work done by Tejun Heo <tj@...nel.org>
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git 
> for-6.10
> 
> Note: Not tested. Please test/review.
> 
> Signed-off-by: Allen Pais <allen.lkml@...il.com>
> ---
> ...
>  drivers/s390/crypto/ap_bus.c           | 24 +++++++-------
>  drivers/s390/crypto/ap_bus.h           |  2 +-
>  drivers/s390/crypto/zcrypt_msgtype50.c |  2 +-
>  drivers/s390/crypto/zcrypt_msgtype6.c  |  4 +--
> ...

Applied and tested the s390 AP bus and zcrypt part of the patch.
Works fine, a sniff test did not show any problems.
Thanks for your work.

Reviewed-by: Harald Freudenberger <freude@...ux.ibm.com>