linux-kernel - Re: [PATCH 3/3] hwmon: (coretemp) Use a model-specific bitmask to read registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48f81be1-b484-45c1-850b-8aa364b8d836@roeck-us.net>
Date: Mon, 8 Apr 2024 04:40:14 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: "Zhang, Rui" <rui.zhang@...el.com>
Cc: "ricardo.neri-calderon@...ux.intel.com" <ricardo.neri-calderon@...ux.intel.com>,
	"Neri, Ricardo" <ricardo.neri@...el.com>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"lukasz.luba@....com" <lukasz.luba@....com>,
	"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
	"jdelvare@...e.com" <jdelvare@...e.com>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 3/3] hwmon: (coretemp) Use a model-specific bitmask to
 read registers

On Sun, Apr 07, 2024 at 08:39:51AM +0000, Zhang, Rui wrote:
> > I do not think it is appropriate to make a hardware monitoring driver
> > depend on the thermal subsystem.
> > 
> > NAK in the current form.
> > 
> Hi, Guenter,
> 
> Thanks for reviewing.
> 
> We've seen a couple of hwmon drivers depends on or imply THERMAL.
> That's why we think this is an applicable solution.

So far this was - unless someone sneaked something by - for drivers
which registered thermal zones, not for calling code which resides
inside thermal subsystem.

> Using the intel_tcc APIs can effectively reduce the future maintenance
> burden because we don't need to duplicate the model list in multiple
> places.
> 
> or do you have any suggestions?

The exported code should reside outside the thermal subsystem.

Also, as implemented, if INTEL_TCC=n, the returned temperature mask value
is 0x7f, and the offset mask is 0. So the alternative would be to just use
those values unconditionally since apparently that is sufficient.

Thanks,
Guenter