linux-kernel - Re: [PATCH 2/4] selftests/arm: Add signal tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f673314c-3a22-4a62-a994-ce6262593914@sirena.org.uk>
Date: Mon, 8 Apr 2024 13:12:21 +0100
From: Mark Brown <broonie@...nel.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Dev Jain <dev.jain@....com>, shuah@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	Anshuman.Khandual@....com, suzuki.poulose@....com,
	ryan.roberts@....com, rob.herring@....com, Catalin.Marinas@....com,
	will@...nel.org, mark.rutland@....com
Subject: Re: [PATCH 2/4] selftests/arm: Add signal tests

On Sun, Apr 07, 2024 at 02:28:06AM +0500, Muhammad Usama Anjum wrote:
> On 4/5/24 1:44 PM, Dev Jain wrote:

> > +	ksft_print_msg("%s :: %s\n", current->name, current->descr);
> > +	if (test_setup(current) && test_init(current)) {
> > +		test_run(current);
> > +		test_cleanup(current);
> > +	}
> > +	test_result(current);
> > +
> > +	return current->result;
> > +}

> This test isn't TAP compliant. Please make this and all tests TAP
> compilant. The 1/4 patch has example of TAP usage.

It's based on the 64 bit version of these tests which are also not TAP
compliant.  TBH I'm not sure how worthwile it is to fix at all given
that they're all single test executables anyway, if it does get fixed
it'd be good to do the arm64 ones as well.

> > +	} else {
> > +		fprintf(stdout, "==>> completed. FAIL(0)\n");
> > +		td->result = KSFT_FAIL;
> > +	}
> > +
> > +	if (force_exit)
> > +		exit(td->result);
> > +}
> > +

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)