linux-kernel - Re: [PATCH] watchdog: bd9576: Drop "always-running" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e5f6d58-b72f-43ba-8280-3cd8b9b974ef@roeck-us.net>
Date: Mon, 8 Apr 2024 05:27:06 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Lee Jones <lee@...nel.org>, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: bd9576: Drop "always-running" property

On Mon, Apr 08, 2024 at 01:02:31PM +0300, Matti Vaittinen wrote:
> The always-running (from linux,wdt-gpio.yaml) is abused by the BD9576
> watchdog driver. It's defined meaning is "the watchdog is always running
> and can not be stopped". The BD9576 watchdog driver has implemented it
> as "start watchdog when loading the module and prevent it from being
> stopped".
> 
> Furthermore, the implementation does not set the WDOG_HW_RUNNING when
> enabling the watchdog due to the "always-running" at module loading.
> This will end up resulting a watchdog timeout if the device is not
> opened.
> 
> The culprit was pointed out by Guenter, discussion can be found from
> https://lore.kernel.org/lkml/4fa3a64b-60fb-4e5e-8785-0f14da37eea2@roeck-us.net/
> 
> Drop the invalid "always-running" handling.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Fixes: b237bcac557a ("wdt: Support wdt on ROHM BD9576MUF and BD9573MUF")

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Guenter