linux-kernel - Re: [PATCH] ASoC: soc-card: Fix a reversed if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25771b56-8564-42c1-9a2d-408d91f23618@sirena.org.uk>
Date: Mon, 8 Apr 2024 13:43:09 +0100
From: Mark Brown <broonie@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Richard Fitzgerald <rf@...nsource.cirrus.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-card: Fix a reversed if condition

On Mon, Apr 08, 2024 at 10:38:02AM +0300, Dan Carpenter wrote:

>  	ret = snd_soc_register_card(priv->card);
> -	if (!ret)
> +	if (ret)
>  		return ret;
>  
>  	return 0;

Clearly a better fix here would just be to remove the conditional
entirely.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)