linux-kernel - Re: [PATCH] soc: mediatek: mtk-socinfo: select CONFIG_SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Apr 2024 13:59:24 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	William-tw Lin <william-tw.lin@...iatek.com>,
	Arnd Bergmann <arnd@...db.de>, Ulf Hansson <ulf.hansson@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mediatek: mtk-socinfo: select CONFIG_SOC_BUS

Hi,

On Mon, Apr 08, 2024 at 02:55:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This is needed to avoid a link failure:
> 
> ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!
> ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!
> 

I've tried to take care of this in the exact same way a long time
ago. Don't ask me why it didn't find it's way into stable yet

https://patchwork.kernel.org/project/linux-mediatek/patch/cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org/


Cheers


Daniel

> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/soc/mediatek/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index 50c664b65f4d..1b7afb19ccd6 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -72,6 +72,7 @@ config MTK_SOCINFO
>  	tristate "MediaTek SoC Information"
>  	default y
>  	depends on NVMEM_MTK_EFUSE
> +	select SOC_BUS
>  	help
>  	  The MediaTek SoC Information (mtk-socinfo) driver provides
>  	  information about the SoC to the userspace including the
> -- 
> 2.39.2
> 
>