linux-kernel - Re: [PATCH] x86/insn_decoder_test: allow longer symbol-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d912f0e0-19d5-4cde-a548-10db94da15a9@yahoo.de>
Date: Mon, 8 Apr 2024 14:51:55 +0200
From: Danilo Krummrich <danilokrummrich@...oo.de>
To: miguel.ojeda.sandonis@...il.com, tglx@...utronix.de, x86@...nel.org,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
 david@...dahead.eu, sergio.collado@...il.com
Cc: davidgow@...gle.com, hpa@...or.com, john.m.baublitz@...il.com,
 linux-kernel@...r.kernel.org, mhiramat@...nel.org, mingo@...nel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] x86/insn_decoder_test: allow longer symbol-names

On 2/20/24 18:07, Miguel Ojeda wrote:
> 
> On Fri, Jan 27, 2023 at 11:39 AM David Rheinsberg <david@...dahead.eu> wrote:
>>
>> The current workaround is to just disable CONFIG_X86_DECODER_SELFTEST, which I thought is a sad state. I can gladly use `256 + KSYM_NAME_LEN` and add a comment ala "room for insn-encoding and a symbol name". Would that be acceptable? The alternative would be to try to dyn-alloc a buffer and increase it to the actual line-length?
> 
> John independently hit this issue again. Could we fix this? Going for
> the `256 + KSYM_NAME_LEN` sounds good enough for the moment since it
> would be a clear improvement, though I agree this could be cleaned up
> further.

I hit this independently as well. Miguel pointed me on this mail thread
when I sent another fix for this in [1].

> 
> Sergio took the approach David suggested in a related patch [1], but
> perhaps it is best to submit the fix on its own so that it is easier
> to put it in. David, would you be so kind as to submit a v2 with that?
> Hopefully x86 can pick it up, otherwise with an Acked-by I am happy to
> take it too; and then Sergio can submit his patch on top again.

Sergio, David: Do you intend to follow up on this? Otherwise, I can also
pick this up and re-submit.

- Danilo

> 
> Thanks!
> 
> (Cc'ing also Masami who wrote this originally)
> 
> [1] https://lore.kernel.org/rust-for-linux/20231119180145.157455-1-sergio.collado@gmail.com/
> 
> Cheers,
> Miguel

[1] https://lore.kernel.org/rust-for-linux/20240325174924.95899-2-dakr@redhat.com/