linux-kernel - Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f89ebad6dcb2161188354f990d3dad1.sboyd@kernel.org>
Date: Sun, 07 Apr 2024 20:29:15 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Johan Hovold <johan+linaro@...nel.org>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Vamshi Gajjela <vamshigajjela@...gle.com>
Cc: Caleb Connolly <caleb.connolly@...aro.org>, linux-kernel@...r.kernel.org, stable@...r.kernel.org, Vamshi Gajjela <vamshigajjela@...gle.com>
Subject: Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

Quoting Vamshi Gajjela (2024-02-28 10:51:16)
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
> 
> Signed-off-by: Vamshi Gajjela <vamshigajjela@...gle.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@...r.kernel.org
> ---

Applied to spmi-next