linux-kernel - Re: [PATCH v2 00/19] ACPI: store owner from modules with acpi_bus_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Apr 2024 16:18:54 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Robert Moore <robert.moore@...el.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Benson Leung <bleung@...omium.org>, 
	Tzung-Bi Shih <tzungbi@...nel.org>, Corentin Chary <corentin.chary@...il.com>, 
	"Luke D. Jones" <luke@...nes.dev>, Hans de Goede <hdegoede@...hat.com>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>, Pali Rohár <pali@...nel.org>, 
	Matan Ziv-Av <matan@...alib.org>, Mattia Dongili <malattia@...ux.it>, 
	Azael Avalos <coproscefalo@...il.com>, Ajay Kaher <akaher@...are.com>, 
	Alexey Makhalov <amakhalov@...are.com>, VMware PV-Drivers Reviewers <pv-drivers@...are.com>, 
	Richard Cochran <richardcochran@...il.com>, "Theodore Ts'o" <tytso@....edu>, 
	"Jason A. Donenfeld" <Jason@...c4.com>, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	acpica-devel@...ts.linux.dev, linux-input@...r.kernel.org, 
	netdev@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	platform-driver-x86@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v2 00/19] ACPI: store owner from modules with acpi_bus_register_driver()

On Thu, Mar 28, 2024 at 8:49 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Changes in v2:
> - Correct input and platform/chrome subjects.
> - Add acks.
> - Link to v1: https://lore.kernel.org/r/20240327-b4-module-owner-acpi-v1-0-725241a2d224@linaro.org
>
> Merging
> =======
> All further patches depend on the first amba patch, therefore one way is
> to ack and take it via one tree, e.g. ACPI.
>
> Description
> ===========
> Modules registering driver with acpi_bus_register_driver() often forget to
> set .owner field.
>
> Solve the problem by moving this task away from the drivers to the core
> amba bus code, just like we did for platform_driver in commit
> 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (19):
>       ACPI: store owner from modules with acpi_bus_register_driver()
>       Input: atlas - drop owner assignment
>       net: fjes: drop owner assignment
>       platform/chrome: wilco_ec: drop owner assignment
>       platform: asus-laptop: drop owner assignment
>       platform: classmate-laptop: drop owner assignment
>       platform/x86/dell: drop owner assignment
>       platform/x86/eeepc: drop owner assignment
>       platform/x86/intel/rst: drop owner assignment
>       platform/x86/intel/smartconnect: drop owner assignment
>       platform/x86/lg-laptop: drop owner assignment
>       platform/x86/sony-laptop: drop owner assignment
>       platform/x86/toshiba_acpi: drop owner assignment
>       platform/x86/toshiba_bluetooth: drop owner assignment
>       platform/x86/toshiba_haps: drop owner assignment
>       platform/x86/wireless-hotkey: drop owner assignment
>       ptp: vmw: drop owner assignment
>       virt: vmgenid: drop owner assignment
>       ACPI: drop redundant owner from acpi_driver
>
>  drivers/acpi/bus.c                        | 9 +++++----
>  drivers/input/misc/atlas_btns.c           | 1 -
>  drivers/net/fjes/fjes_main.c              | 1 -
>  drivers/platform/chrome/wilco_ec/event.c  | 1 -
>  drivers/platform/x86/asus-laptop.c        | 1 -
>  drivers/platform/x86/classmate-laptop.c   | 5 -----
>  drivers/platform/x86/dell/dell-rbtn.c     | 1 -
>  drivers/platform/x86/eeepc-laptop.c       | 1 -
>  drivers/platform/x86/intel/rst.c          | 1 -
>  drivers/platform/x86/intel/smartconnect.c | 1 -
>  drivers/platform/x86/lg-laptop.c          | 1 -
>  drivers/platform/x86/sony-laptop.c        | 2 --
>  drivers/platform/x86/toshiba_acpi.c       | 1 -
>  drivers/platform/x86/toshiba_bluetooth.c  | 1 -
>  drivers/platform/x86/toshiba_haps.c       | 1 -
>  drivers/platform/x86/wireless-hotkey.c    | 1 -
>  drivers/ptp/ptp_vmw.c                     | 1 -
>  drivers/virt/vmgenid.c                    | 1 -
>  include/acpi/acpi_bus.h                   | 8 ++++++--
>  19 files changed, 11 insertions(+), 28 deletions(-)
> ---

Whole series applied as 6.10 material, thanks!