linux-kernel - Re: [PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZhQJNMM4J2KAAycn@smile.fi.intel.com>
Date: Mon, 8 Apr 2024 18:11:48 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Guanbing Huang <albanhuang@...look.com>
Cc: gregkh@...uxfoundation.org, rafael.j.wysocki@...el.com,
	linux-acpi@...r.kernel.org, tony@...mide.com,
	john.ogness@...utronix.de, yangyicong@...ilicon.com,
	jirislaby@...nel.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, lvjianmin@...ngson.cn,
	albanhuang@...cent.com, tombinfan@...cent.com
Subject: Re: [PATCH v5 0/3] serial: 8250_pnp: Support configurable reg shift
 property

On Mon, Apr 08, 2024 at 06:10:13PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 08, 2024 at 11:36:21AM +0800, Guanbing Huang wrote:
> > From: Guanbing Huang <albanhuang@...cent.com>
> > 
> > The 16550a serial port based on the ACPI table requires obtaining the
> > reg-shift attribute. In the ACPI scenario, If the reg-shift property
> > is not configured like in DTS, the 16550a serial driver cannot read or
> > write controller registers properly during initialization.
> > 
> > To address the issue of configuring the reg-shift property, the 
> > __uart_read_properties() universal interface is called to implement it.
> > Adaptation of PNP devices is done in the __uart_read_properties() function.
> 
> Seems okay to me now,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Note, you have an issue with your email server. The cover letter is not chained
with the patch series. You really want to fix that if you wish to contribute
to Linux kernel project via respective mailing lists.

-- 
With Best Regards,
Andy Shevchenko