linux-kernel - Re: [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC41dw-Df3L7B=Tq2QkQHDT2Yf3MzHgy8-czPAkZhdPf0Tea4Q@mail.gmail.com>
Date: Mon, 8 Apr 2024 08:42:48 -0700
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1] ACPI: Declare acpi_blacklisted() only if CONFIG_X86 is enabled

On Mon, Apr 8, 2024 at 7:53 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Sat, Apr 06, 2024 at 11:33:41PM -0700, Kuppuswamy Sathyanarayanan wrote:
> > The function acpi_blacklisted() is defined only when CONFIG_X86 is
> > enabled. So to keep it consistent, protect its declaration with
> > CONFIG_X86.
>
> ...
>
> >  extern char acpi_video_backlight_string[];
> >  extern long acpi_is_video_device(acpi_handle handle);
> > +#ifdef CONFIG_X86
> >  extern int acpi_blacklisted(void);
> > +#endif
> >  extern void acpi_osi_setup(char *str);
> >  extern bool acpi_osi_is_win8(void);
>
> IIRC there is already similar ifdeffery, can we just move the declaration
> there?

There is none for CONFIG_X86. We only have some combinations or
derived config checks like below:

#if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH)
#ifdef CONFIG_X86_IO_APIC

>
> --
> With Best Regards,
> Andy Shevchenko
>
>