linux-kernel - Re: [PATCH 1/4] x86/cpu: Add and use new CPUID region helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240408162505.GAZhQaYYJ7wrPpaPjj@fat_crate.local>
Date: Mon, 8 Apr 2024 18:25:05 +0200
From: Borislav Petkov <bp@...en8.de>
To: Jürgen Groß <jgross@...e.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, x86@...nel.org, kai.huang@...el.com
Subject: Re: [PATCH 1/4] x86/cpu: Add and use new CPUID region helper

On Thu, Apr 04, 2024 at 11:04:49AM +0200, Jürgen Groß wrote:
> Aren't you missing "width &= 0xff;" here? get_cpuid_region_leaf() doesn't
> truncate the returned value, which has the linear address width at bits 8-15.

Yeah.

Other than that, the intention looks ok as it documents what that code
magic was.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette