linux-kernel - Re: [PATCH net-next v5 1/9] net: dsa: add support for DCB get/set apptrust configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 14:03:50 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
CC: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Vladimir
 Oltean" <olteanv@...il.com>, Woojung Huh <woojung.huh@...rochip.com>, "Arun
 Ramadoss" <arun.ramadoss@...rochip.com>, Florian Fainelli
	<florian.fainelli@...adcom.com>, <kernel@...gutronix.de>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, David Ahern <dsahern@...nel.org>, "Simon
 Horman" <horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
	Søren Andersen <san@...v.dk>
Subject: Re: [PATCH net-next v5 1/9] net: dsa: add support for DCB get/set
 apptrust configuration

Hi Oleksij

> +static int __maybe_unused
> +dsa_user_dcbnl_set_apptrust(struct net_device *dev, u8 *sel, int nsel)
> +{
> +       struct dsa_port *dp = dsa_user_to_port(dev);
> +       struct dsa_switch *ds = dp->ds;
> +       int port = dp->index;
> +

This should be !ds->ops->port_set_apptrust, right :-)

> +       if (!ds->ops->port_get_apptrust)
> +               return -EOPNOTSUPP;
> +
> +       return ds->ops->port_set_apptrust(ds, port, sel, nsel);
> +}