linux-kernel - Re: [PATCH v2] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZ+DNkb4bC8eSQaxcDFEuA4hWJMgk00r6+YKc+BH953x+w@mail.gmail.com>
Date: Tue, 9 Apr 2024 10:23:23 -0400
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Werner Sembach <wse@...edocomputers.com>
Cc: Marcel Holtmann <marcel@...tmann.org>, Christoffer Sandberg <cs@...edo.de>, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED

Hi Werner,

On Mon, Apr 8, 2024 at 8:35 AM Werner Sembach <wse@...edocomputers.com> wrote:
>
> From: Christoffer Sandberg <cs@...edo.de>
>
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through
> the existing quirk.

Perhaps the following could be a proper fix for that:

https://patchwork.kernel.org/project/bluetooth/patch/20240405204037.3451091-1-luiz.dentz@gmail.com/

If you manage to test it please reply and add Tested-by to its thread.

> Signed-off-by: Christoffer Sandberg <cs@...edo.de>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> Cc: <stable@...r.kernel.org>
> ---
>  drivers/bluetooth/btintel.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index cdc5c08824a0a..9f9c4696d082a 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,9 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>         case 0x17:
>         case 0x18:
>         case 0x19:
> +               /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
> +               set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> +               fallthrough;
>         case 0x1b:
>         case 0x1c:
>                 /* Display version information of TLV type */
> --
> 2.34.1
>


-- 
Luiz Augusto von Dentz