linux-kernel - Re: [PATCH] cpufreq: Convert to exit callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7abe982f-54cc-4288-a410-df43cec68f67@csgroup.eu>
Date: Tue, 9 Apr 2024 15:05:14 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Lizhe <sensor1010@....com>, "mpe@...erman.id.au" <mpe@...erman.id.au>,
	"npiggin@...il.com" <npiggin@...il.com>, "aneesh.kumar@...nel.org"
	<aneesh.kumar@...nel.org>, "naveen.n.rao@...ux.ibm.com"
	<naveen.n.rao@...ux.ibm.com>, "rafael@...nel.org" <rafael@...nel.org>,
	"viresh.kumar@...aro.org" <viresh.kumar@...aro.org>, "andersson@...nel.org"
	<andersson@...nel.org>, "konrad.dybcio@...aro.org"
	<konrad.dybcio@...aro.org>, "sudeep.holla@....com" <sudeep.holla@....com>,
	"cristian.marussi@....com" <cristian.marussi@....com>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>, "jonathanh@...dia.com"
	<jonathanh@...dia.com>
CC: "inuxppc-dev@...ts.ozlabs.org" <inuxppc-dev@...ts.ozlabs.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Convert to exit callback returning void



Le 09/04/2024 à 16:53, Lizhe a écrit :
> For the exit() callback function returning an int type value,
> this leads many driver authors mistakenly believing that error
> handling can be performed by returning an error code. However,
> the returned value is ignored, and to improve this situation,
> it is proposed to modify the return type of the exit() callback
> function to void.
> 
> Signed-off-by: Lizhe <sensor1010@....com>
> ---
>   drivers/cpufreq/pasemi-cpufreq.c       | 4 +---
>   drivers/cpufreq/powernv-cpufreq.c      | 4 +---
>   drivers/cpufreq/ppc_cbe_cpufreq.c      | 3 +--
>   drivers/cpufreq/qcom-cpufreq-hw.c      | 4 +---
>   drivers/cpufreq/qoriq-cpufreq.c        | 4 +---
>   drivers/cpufreq/scmi-cpufreq.c         | 4 +---
>   drivers/cpufreq/scpi-cpufreq.c         | 4 +---
>   drivers/cpufreq/sh-cpufreq.c           | 4 +---
>   drivers/cpufreq/sparc-us2e-cpufreq.c   | 3 +--
>   drivers/cpufreq/sparc-us3-cpufreq.c    | 3 +--
>   drivers/cpufreq/speedstep-centrino.c   | 4 +---
>   drivers/cpufreq/tegra194-cpufreq.c     | 4 +---
>   drivers/cpufreq/vexpress-spc-cpufreq.c | 3 +--
>   13 files changed, 13 insertions(+), 35 deletions(-)

Did you do a building test ?

How can this work without changing the definition of exit in struct 
cpu_freq driver in include/linux/cpufreq.h ?

Christophe