linux-kernel - Re: [PATCH] usb/dwc3: replace of_node_put with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024040953-blade-entryway-5091@gregkh>
Date: Tue, 9 Apr 2024 17:19:27 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Andrew Ballance <andrewjballance@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Thinh.Nguyen@...opsys.com,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] usb/dwc3: replace of_node_put with __free

On Fri, Apr 05, 2024 at 09:48:38PM -0500, Andrew Ballance wrote:
> this relaces instances of of_node_put with __free(device_node)
> in drivers/usb/dwc3/core.c

Why?  You need to always describe _why_ you do something, not _what_ you
do.

thanks,

greg k-h